Allow jitter for all backoff types #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
approved these changes
Jul 28, 2023
| @@ -34,6 +34,18 @@ public class RetryStrategyOptions<TResult> : ResilienceStrategyOptions | |||
| /// </value> | |||
| public RetryBackoffType BackoffType { get; set; } = RetryConstants.DefaultBackoffType; | |||
|
|
|||
| /// <summary> | |||
| /// Gets or sets a value indicating whether the jitter should be used when calculating the backoff delay between retries. | |||
There was a problem hiding this comment.
Suggested change
| /// Gets or sets a value indicating whether the jitter should be used when calculating the backoff delay between retries. | |
| /// Gets or sets a value indicating whether jitter should be used when calculating the backoff delay between retries. |
Codecov Report
@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
+ Coverage 83.83% 83.97% +0.13%
==========================================
Files 274 276 +2
Lines 6491 6544 +53
Branches 1008 1015 +7
==========================================
+ Hits 5442 5495 +53
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
For context:
https://github.com/App-vNext/Polly/pull/1233/files#r1251595389
If jitter is used, then the final delay is randomized between the factor of
1...1.5.This applies for constant and linear delay, for exponential delay the formula is more complicated. (no changes)
Contributes to #1301
Confirm the following